Skip to content

Update lsdb version and remove universal_pathlib in requirements.txt #151

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Oct 3, 2025
Merged

Update lsdb version and remove universal_pathlib in requirements.txt #151

merged 2 commits into from
Oct 3, 2025

Conversation

@jaladh-singhal
Copy link
Member

@jaladh-singhal jaladh-singhal commented Oct 3, 2025

astronomy-commons/lsdb#1047 (comment) - the bug with universal_pathlib got resolved

@jaladh-singhal jaladh-singhal requested a review from bsipocz October 3, 2025 21:36
@jaladh-singhal jaladh-singhal self-assigned this Oct 3, 2025
@jaladh-singhal jaladh-singhal added bug Something isn't working infrastructure Infrastructure related issues/PRs. GHA buildhtml Enable extra buildhtml job on GHA labels Oct 3, 2025
@jaladh-singhal jaladh-singhal reopened this Oct 3, 2025
troyraen
troyraen reviewed Oct 3, 2025
View reviewed changes
Copy link
Contributor

@troyraen troyraen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also remove it from the pip install cell in the notebook.

@jaladh-singhal
Copy link
Member Author

jaladh-singhal commented Oct 3, 2025

Also remove it from the pip install cell in the notebook.

Jinx, just did!

@jaladh-singhal
Copy link
Member Author

jaladh-singhal commented Oct 3, 2025 •
edited
Loading

I re-ran buildhtml and build-docs pipeliens, but they are still failing because of some unrelated error:

For build-docs, it's:

py312-buildhtml: commands[9]> bash -c 'if grep -q '"'"'Traceback .most recent call last.'"'"' /tmp/mystbuild.log; then exit 1; fi'
py312-buildhtml: commands[10]> bash -c 'rm _build/html/*thebe*.js'
rm: cannot remove '_build/html/*thebe*.js': No such file or directory
py312-buildhtml: exit 1 (0.01 seconds) /home/circleci/project> bash -c 'rm _build/html/*thebe*.js' pid=3085
  py312-buildhtml: FAIL code 1 (183.08=setup[75.65]+cmd[0.44,0.00,0.05,0.03,0.00,0.00,0.00,0.04,106.84,0.01,0.01] seconds)
  evaluation failed :( (183.12 seconds)

For buildhtml, it was the same rm: cannot remove '_build/html/*thebe*.js': No such file or directory error in the first run. Now it's just SIGTERM (exit code 143)

bsipocz
bsipocz reviewed Oct 3, 2025
View reviewed changes
Copy link
Member

@bsipocz bsipocz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would carefully double check what other implicit dependency changes would this jump in version mean, lsdb notorious with its hats --> nested_pandas-->pandas and pyarrow chains of requirements and aggressively pinning those.

bsipocz
bsipocz approved these changes Oct 3, 2025
View reviewed changes
Copy link
Member

@bsipocz bsipocz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK, I've checked the chain of deps and it looks OK.

(well, I still don't like how they upper pin, but we can't do much about that, what's important here is that this doesn't bring in any changes to the minimums).

@bsipocz
Copy link
Member

bsipocz commented Oct 3, 2025

FYI, this error suggest a running out of resources. Let's see if it's consistently around or not.

📖 Built tutorials/firefly/OpenUniverse2024Preview_Firefly.md in 1.38 min.
📖 Built tutorials/euclid_access/1_Euclid_intro_MER_images.md in 1.73 min.
Kernel: restarting (1627a44f-7572-46f7-b03e-213b88fe0283)
Kernel: autorestarting (1627a44f-7572-46f7-b03e-213b88fe0283)
Connection lost, reconnecting in 0 seconds.
Starting WebSocket: ws://localhost:8888/api/kernels/1627a44f-7572-46f7-b03e-213b88fe0283
Canceled future for execute_request message before replies were done


Myst CLI Versions:
 - node                        22.20.0     Required: >= 18.0.0      
 - npm                          10.9.3     Required: >=8.6.0        
 - myst                          1.6.0     


py312-buildhtml: commands[9]> bash -c 'if grep -q '"'"'Traceback .most recent call last.'"'"' /tmp/mystbuild.log; then exit 1; fi'
py312-buildhtml: commands[10]> bash -c 'rm _build/html/*thebe*.js'
rm: cannot remove '_build/html/*thebe*.js': No such file or directory
py312-buildhtml: exit 1 (0.00 seconds) /home/circleci/project> bash -c 'rm _build/html/*thebe*.js' pid=3092
  py312-buildhtml: FAIL code 1 (210.73=setup[89.83]+cmd[0.49,0.01,0.04,0.04,0.00,0.00,0.00,0.03,120.28,0.00,0.00] seconds)
  evaluation failed :( (210.76 seconds)

@bsipocz bsipocz merged commit 7effa95 into Caltech-IPAC:main Oct 3, 2025
22 of 26 checks passed
@bsipocz
Copy link
Member

bsipocz commented Oct 3, 2025

Thanks @jaladh-singhal!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@troyraen troyraen troyraen left review comments

@bsipocz bsipocz bsipocz approved these changes

Assignees

@jaladh-singhal jaladh-singhal

Labels

bug Something isn't working GHA buildhtml Enable extra buildhtml job on GHA infrastructure Infrastructure related issues/PRs.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@jaladh-singhal @bsipocz @troyraen